Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development of API-based errant_compare #50

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

gotutiyan
Copy link

@gotutiyan gotutiyan commented Mar 26, 2024

Hi, as can be seen in the issue #25, I think API-based errant_compare feature will be useful for many people.
I also want the feature so I created a pilot version.
Mainly,

  • Overall, the implementation does not use coder_dict, but uses the Edit object directly.
  • Created errant/compare.py and implement the API-based errant_compare
  • Added __eq__() function to the Edit class to compare two objects easily.
  • All of options used in the official are supported (i.e. -cs, -ds, -dt, -cse, -single, -multi, -cat and -filt)

Using the GEC system's correction results at hand, I confirmed that the results of the official implementation match the results of my implementation.

I do not think this PR will be merged as is, but I hope this is a clue to development of API-based errant_compare!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant