Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow passing arguments to the browser opener #17

Merged
merged 1 commit into from
Apr 22, 2023
Merged

feat: allow passing arguments to the browser opener #17

merged 1 commit into from
Apr 22, 2023

Conversation

dsully
Copy link
Contributor

@dsully dsully commented Apr 22, 2023

Fix some spelling / capitalization as well.

@chrishrb
Copy link
Owner

Thanks for submitting this PR, it looks good to me. Somehow the --background doesn‘t work with chrome on macOs but that looks like an issue of chrome on macOs and not your changes 👍

@dsully
Copy link
Contributor Author

dsully commented Apr 22, 2023

Ok - I use Safari and it works great there.

@chrishrb chrishrb merged commit e5b7694 into chrishrb:main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishrb chrishrb chrishrb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsully @chrishrb