Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handler for git commit hash #15

Merged
merged 7 commits into from
Apr 19, 2023
Merged

Add handler for git commit hash #15

merged 7 commits into from
Apr 19, 2023

Conversation

CKolkey
Copy link
Contributor

@CKolkey CKolkey commented Apr 19, 2023

Adds handler for a commit hash under cursor.

@chrishrb
Copy link
Owner

nice handler! could be please add some tests also so we can assure that this feature works as expected?

@CKolkey
Copy link
Contributor Author

CKolkey commented Apr 19, 2023

Sure thing.

Copy link
Owner

@chrishrb chrishrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think with those changes, the tests should pass and we can merge the PR

test/spec/gx/handlers/commit_handler_spec.lua Outdated Show resolved Hide resolved
test/spec/gx/handlers/commit_handler_spec.lua Outdated Show resolved Hide resolved
CKolkey and others added 2 commits April 19, 2023 18:25
Co-authored-by: Christoph  <52382992+chrishrb@users.noreply.github.com>
Co-authored-by: Christoph  <52382992+chrishrb@users.noreply.github.com>
@chrishrb chrishrb merged commit 2281cab into chrishrb:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants