Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also include OTEL's Resource Detector, which picks up standard envvars #13

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

chrisguidry
Copy link
Owner

Fixes #12

Tested with both the OTEL_SERVICE_NAME and OTEL_RESOURCE_ATTRIBUTES:

$ OTEL_SERVICE_NAME=example-name pytest --export-traces
$ OTEL_RESOURCE_ATTRIBUTES=service.name=example-name pytest --export-traces

@chrisguidry chrisguidry merged commit 23ca690 into main Sep 7, 2022
@chrisguidry chrisguidry deleted the service-name branch September 7, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better service name detection
1 participant