Add best-effort cancellation of running tasks #261
+545
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `docket.cancel(key)` is called for a task that's currently executing on a worker, the worker now receives a signal via Redis pub/sub and cancels the asyncio task. Tasks see standard `asyncio.CancelledError`, same as timeouts. If a task catches and swallows the CancelledError, it continues to completion normally - respecting the task's choice. Also refactors `mark_as_completed`, `mark_as_failed`, and `mark_as_cancelled` into a common `_mark_as_terminal` helper to reduce duplication. Closes #183 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
📚 Documentation has been built for this PR! You can download the documentation directly here: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 53 54 +1
Lines 8620 8873 +253
Branches 434 438 +4
==========================================
+ Hits 8620 8873 +253
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Verifies that cancelled tasks do not retry (even with Retry dependency) and do not perpetuate (even with Perpetual dependency). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
docket.cancel(key)is called for a task that's currently executing on aworker, the worker now receives a signal via Redis pub/sub and cancels the
asyncio task. Tasks see standard
asyncio.CancelledError, same as timeouts.If a task catches and swallows the CancelledError, it continues to completion
normally - respecting the task's choice.
Also refactors
mark_as_completed,mark_as_failed, andmark_as_cancelledinto a common
_mark_as_terminalhelper to reduce duplication.Closes #183
🤖 Generated with Claude Code