Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml for Custom Node Registry #194

Merged
merged 2 commits into from
May 20, 2024

Conversation

haohaocreates
Copy link
Contributor

We are building a global registry for custom nodes (similar to PyPI). The registry makes using custom nodes more reliable by reserving globally unique names for each custom node, and supporting semantic versioning.

Here’s some more information on the registry.

Action Required:

  • Go to the registry. Login and create a publisher id. Comment it here and we will update the PR (or just merge it and change it yourself).
  • Write a short the description.
  • Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish

Please message me on Discord if you have any questions!

@chrisgoringe
Copy link
Owner

Logged into registry, but when I try to create a publisher:
Screenshot 2024-05-17 120357
I get
Screenshot 2024-05-17 120348
However often I try...

@robinjhuang
Copy link

@chrisgoringe Sorry, it's not very clear but publisher names should be lowercase. We treat them as case-insensitive when seeing if there are conflicts.

Added publisher id
@chrisgoringe chrisgoringe merged commit 4dc0cea into chrisgoringe:main May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants