Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #89. #94

Merged
merged 1 commit into from
Jan 6, 2014
Merged

Fixes #89. #94

merged 1 commit into from
Jan 6, 2014

Conversation

chrisdembia
Copy link
Owner

No description provided.

@chrisdembia
Copy link
Owner Author

@moorepants , please peek at this, and merge if you think it's fine.

@moorepants
Copy link
Collaborator

Looks fine, seems like the same test we have in two other places now.

@moorepants
Copy link
Collaborator

This is a good addition. I does test it more directly.

@chrisdembia
Copy link
Owner Author

Yeah it's the same type of test but it's testing different code.

@chrisdembia
Copy link
Owner Author

Thanks for looking.

chrisdembia added a commit that referenced this pull request Jan 6, 2014
@chrisdembia
Merge pull request #94 from chrisdembia/issue89
d0ed230 
Fixes #89.
@chrisdembia chrisdembia merged commit d0ed230 into master Jan 6, 2014
@chrisdembia chrisdembia deleted the issue89 branch January 6, 2014 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisdembia @moorepants