Added recursive constructor option to allow for reviver functions #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameters allows for opting out of recursive parsing of the JsonObject value. Default behaviour is not changed.
stevenroose
changed the title
stevenroose
changed the title
stevenroose
added a commit
that referenced
this pull request
Mar 31, 2015
Merge PR: Added recursive constructor option to allow for reviver functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally made this PR from my master branch, so I made an additional commit from it. However, both changed are very minor and do not break anything.
First: the field
_jsonStringholds the stringified version of the object, but it is never used. ThetoString()method uses theJsonEncoder. So I deleted this field.Second:
JsonDecoderallows for the use of a reviver-method. This way, people can convert json objects to their own classes. The fact thatJsonObjectalways recursively converts all underlying data toJsonObjects, breaks reviver functionality. So I added an optionalbool recursiveparameter toJsonObject.fromMapto allow for the usage of revivers along withJsonObject. I use it myself and it works just fine.