Skip to content

Commit

Permalink
deps: Use PR branch (zulip#328) for @react-native-community/cameraroll.
Browse files Browse the repository at this point in the history
Just while we wait for the code in this package to be error-free
when exact_by_default is enabled [1]. We plan to enable it for the
RN v0.64 upgrade (zulip#4426). The PR is
  react-native-cameraroll/react-native-cameraroll#328.

It's very possible that some of those object types would be better
as exact instead of inexact. But:

1. Just getting the library to pass the implicit-inexact-object lint
   is enough to unblock switching on exact_by_default (for us and
   for other projects that want to do that too).

2. I guess we could go through and decide what should stay inexact
   and what should be made exact. But then each of those choices
   would have to be approved, and some of them would probably be
   breaking changes that we'd need to write changelog entries for.
   (Not ones that would affect an app at runtime -- but still, apps
   that use Flow would predictably have to change their code to
   adapt.)

[1] https://medium.com/flow-type/how-to-upgrade-to-exact-by-default-object-type-syntax-7aa44b4d08ab
  • Loading branch information
chrisbobbe committed Sep 1, 2021
1 parent a1fcee1 commit a93ef1a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"@expo/react-native-action-sheet": "^3.8.0",
"@react-native-async-storage/async-storage": "^1.13.0",
"@react-native-community/cameraroll": "^4.0.4",
"@react-native-community/cameraroll": "chrisbobbe/react-native-cameraroll#17fa5d8d2",
"@react-native-community/masked-view": "^0.1.10",
"@react-native-community/netinfo": "^6.0.0",
"@react-native-community/push-notification-ios": "^1.5.0",
Expand Down
5 changes: 2 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2192,10 +2192,9 @@
dependencies:
deep-assign "^3.0.0"

"@react-native-community/cameraroll@^4.0.4":
"@react-native-community/cameraroll@chrisbobbe/react-native-cameraroll#17fa5d8d2":
version "4.0.4"
resolved "https://registry.yarnpkg.com/@react-native-community/cameraroll/-/cameraroll-4.0.4.tgz#3e2567ce54e3985e8e0a51832dfa0e1c5317f75b"
integrity sha512-3SY96Xh1yQjV5M7dFisl5kQmrO/K09URarZwmTN801KEalOoo/opsd/e8Vu1dwSKe0NGCK7A2u0oJQpeNbWbnA==
resolved "https://codeload.github.com/chrisbobbe/react-native-cameraroll/tar.gz/17fa5d8d2f4e00ec78304070a0b91292e884b7f5"

"@react-native-community/cli-debugger-ui@^4.13.1":
version "4.13.1"
Expand Down

0 comments on commit a93ef1a

Please sign in to comment.