Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing argument error #2286

Closed
wants to merge 1 commit into from

Conversation

pixelasticity
Copy link

I get an error from the set_cookie function due to a missing argument

Types of change(s)

Bug fix

What is the new behavior?

Doesn't change any behavior - only removes an error that can occur

I get an error from the set_cookie function due to a missing argument
@chrisblakley
Copy link
Owner

Thanks for this– what I may do to resolve this is set that third parameter to false by default at the function declaration itself so that this instance can be resolved, but also it can resolve any other similar instances.

So in /libs/Utilities/Utilities.php I've tried changing this:

public function set_cookie($name, $value, $expiration){

to this:

public function set_cookie($name, $value, $expiration=false){

Lemme know if that also works for you, and if not we can look into altering the individual function calls.

@pixelasticity
Copy link
Author

That definitely works for me. Thanks for all your work on Nebula, it's great!

@chrisblakley
Copy link
Owner

Great– I will include this with the next commit this weekend– thanks again.

chrisblakley added a commit that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants