Update simple-get 2.4.0 to 4.0.1. #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This potentially fixes a security vulnerability in the dependency. The breaking changes from 2.4.0 to 4.0.1 involved adoption of ES6 and dropping support for EOL Node.js versions. Neither should be a problem here, I would expect. Reference: GHSA-wpg7-2c88-r8xv
Contributor
Author
|
I suppose this repo is inactive. |
Owner
|
Unfortunately GitHub had stopped sending me emails and notifications, I will check this out tomorrow but as all tests have passed it should be good to go. Thanks for this, and sorry for the delay. |
Contributor
Author
|
Coverage change doesn't seem related, does it? |
Owner
|
I can't work out what's caused the coverage dip, will spend some time figuring it out. Merged and published, thanks for the commit and it should be on npm as version 2.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially fixes a security vulnerability in the dependency.
The breaking changes from 2.4.0 to 4.0.1 involved adoption of ES6
and dropping support for EOL Node.js versions. Neither should be a
problem here, I would expect.
Reference: GHSA-wpg7-2c88-r8xv