Skip to content

Remove duplicate call to service.fetchImage in onAppear #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

nmandica
Copy link
Contributor

The double call to service.fetchImage was causing the following error log: finished with error [-999] Error Domain=NSURLErrorDomain Code=-999.

…e following error "finished with error [-999] Error Domain=NSURLErrorDomain Code=-999"
@codecov-commenter
Copy link

Codecov Report

Merging #10 into master will increase coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   91.17%   91.79%   +0.61%     
==========================================
  Files          10       10              
  Lines         136      134       -2     
==========================================
- Hits          124      123       -1     
+ Misses         12       11       -1     
Impacted Files Coverage Δ
Sources/RemoteImage/public/Views/RemoteImage.swift 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd92986...b5de0e1. Read the comment docs.

@chris-swift-dev
Copy link
Owner

Thank you @nmandica 👍

@chris-swift-dev chris-swift-dev merged commit 2dca777 into chris-swift-dev:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants