Adding optional interfaceAssociatedAddress to to UDPReceiver/UDPSender/OD4Session c'tor#13
Open
freol35241 wants to merge 2 commits intochrberger:masterfrom
Open
Conversation
…address to be used when joining a multicast group.
…r the OD4Session.
9360598 to
eed9266
Compare
Author
|
@chrberger I am a bit unsure whether I managed to put all the ifdef blocks for the different OS:s correctly. There are some parts of the existing ones I cant wrap my head around... Also, if you have an idea about how to include this in the automatic test suite, I am all ears. Now, some holidays, so no need to stress the review ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding optional constructor argument for allowing explicit interface address to be used when joining a multicast group. This makes it possible to explicitly set which interface that should be used when joining a multicast group on a computer with multiple NICs.