[5429] Add new rules to Checkstyle - Blocks

chowyb · May 24, 2016 · 8ec44ac · 8ec44ac
1 parent fe0376e
commit 8ec44ac
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/test/java/teammates/test/pageobjects/InstructorCourseEditPage.java b/src/test/java/teammates/test/pageobjects/InstructorCourseEditPage.java
@@ -182,6 +182,7 @@ public void closeModal() {
         try {
             Thread.sleep(1000);
         } catch (InterruptedException e) {
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/static-analysis/teammates-checkstyle.xml b/static-analysis/teammates-checkstyle.xml
@@ -62,6 +62,12 @@
     </module>
     <module name="LocalVariableName"/>
     <module name="ParameterName"/>
+    <module name="AvoidNestedBlocks"/>
+    <module name="EmptyBlock">
+      <property name="option" value="text"/>
+      <property name="tokens" value="LITERAL_CATCH,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,INSTANCE_INIT,STATIC_INIT,LITERAL_SWITCH,LITERAL_TRY,LITERAL_WHILE"/>
+    </module>
+    <module name="EmptyCatchBlock"/>
     <module name="EmptyStatement"/>
     <module name="DefaultComesLast"/>
     <module name="ExplicitInitialization"/>
-Original file line number
+Diff line change
@@ Expand Up / @@ -182,6 +182,7 @@ public void closeModal() { @@
             try {
                 Thread.sleep(1000);
             } catch (InterruptedException e) {
+                throw new RuntimeException(e);
             }
         }
@@ Expand Down @@