sync #19
Merged
sync #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can just reset the filename_override to NULL in php_request_shutdown. Closes GH-9805
* PHP-8.2: Remove unnecessary ast eval bailout
* PHP-8.1: Add missing EXTENSION section to tests
* PHP-8.2: Add missing EXTENSION section to tests
Closes GH-9841
The test assumes that the hard-limit is unlimited at script entrance which doesn't hold on the second run.
* PHP-8.1: Add NEWS entry for #9841
* PHP-8.2: Add NEWS entry for #9841
#9839) * Fix pre-PHP 8.2 compatibility for php_mt_rand_range() with MT_RAND_PHP As some left-over comments indicated: > Legacy mode deliberately not inside php_mt_rand_range() > to prevent other functions being affected The broken scaler was only used for `php_mt_rand_common()`, not `php_mt_rand_range()`. The former is only used for `mt_rand()`, whereas the latter is used for `array_rand()` and others. With the refactoring for the introduction of ext/random `php_mt_rand_common()` and `php_mt_rand_range()` were accidentally unified, thus introducing a behavioral change that was reported in FakerPHP/Faker#528. This commit moves the checks for `MT_RAND_PHP` from the general-purpose `range()` function back into `php_mt_rand_common()` and also into `Randomizer::getInt()` for drop-in compatibility with `mt_rand()`. * [ci skip] NEWS for `MT_RAND_PHP` compatibility
* PHP-8.2: Fix pre-PHP 8.2 compatibility for php_mt_rand_range() with MT_RAND_PHP (#9839)
SaltStack uses Python subprocess and redirects stderr to stdout which is then piped to the returned output. If php-fpm starts in daemonized mode, it should close stderr. However a fix introduced in GH-8913 keeps stderr around so it can be later restored. That causes the issue reported in GH-9754. The solution is to keep stderr around only when php-fpm runs in foreground as the issue is most likely visible only there. Basically there is no need to restore stderr when php-fpm is daemonized.
* PHP-8.2: Do not display the value of UNKNOWN constants in the manual (#9843)
If an installed php.ini turns expose_php on/off, and an FPM pool overrides that with php_flag[expose_php]=off/on, a status pool created with pm.status_listen in a pool config will have its expose_php reflect the php.ini value, and not the pool config's override. This change looks for an override set in php_flag/php_value/php_admin_flag/php_admin_value and carries that through.
This is to allow more time to switch for active to idle in scoreboard as it seems that Travis is quite short on resources and might not switch it quickly enough.
* PHP-8.2: [ci skip] Update PHP 8.2.0 new release date
There might be a moment when the child log event is executed after freeing a child. That could possibly happen if the child output is triggered at the same as the terminating of the child. Then the output event could be potentially processed after the terminating event which would cause this kind of issue. The issue might got more visible after introducing the log_stream on a child because it is more likely that this cannot be dereferenced after free. However it is very hard to reproduce this issue so there is no test for this. The fix basically prevents passing a child pointer and instead passes the child PID and then looks the child up by the PID when it is being processed. This is obviously slower but it is a safe way to do it and the slow down should not be hopefully visible in a way that it would overload a master process.
* PHP-8.1: [ci skip] NEWS Do not resolve constants on non-linked class during preloading (#9975)
* PHP-8.2: [ci skip] NEWS [ci skip] NEWS Do not resolve constants on non-linked class during preloading (#9975)
To keep the diff cleaner for future changes, such as #9664.
* PHP-8.2: [ci skip] random: Trim trailing whitespace in randomizer.c
When decoding a 3-byte UTF-8 code unit, redundant checks for overlong
code unit and for illegal codepoints from U+D800-DFFF were included.
Both of these conditions are caught by the line which reads:
if ((c2 & 0xC0) != 0x80 || (c == 0xF0 && c2 < 0x90) || (c == 0xF4 && c2 >= 0x90)) {
As such, there is no reason to check for the same error conditions again.
Likewise, when decoding a 4-byte UTF-8 code unit, there was a
redundant check for overlong code unit. That was already caught by the
line which reads:
if ((c2 & 0xC0) != 0x80 || (c == 0xF0 && c2 < 0x90) || (c == 0xF4 && c2 >= 0x90)) {
We call dlerror when a library failed to load properly. Closes GH-9913.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.