Use Object.assign instead of xtend #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described by choojs#563: > https://polyfill.io provides a fallback for browsers that don't support it, so for most people this will be a strict improvement.
|
Ohhh, yeah I really want to merge this. But we're still supporting IE11, so that would be a breaking change. Leaving this open until we're ready to merge Choo v7 patches. Thanks a lot! ✨ |
|
I'm currently putting together a change log for v7.0.0 and would like to get this in there. @nanaian would you mind fixing the merge conflict? |
|
@tornqvist should be good to merge now! |
This was referenced Jun 8, 2019
goto-bus-stop
approved these changes
Jun 9, 2019
tornqvist
added a commit
to tornqvist/choo
that referenced
this pull request
Jun 11, 2019
* master: Update nanorouter (choojs#701) Use Object.assign instead of xtend (choojs#616)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by #563: