Miscellaneous Post MHD Tweaks/Fixes #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of timesteps differs between the MHD and hydro versions of the tests but that wasn't acounted for. Now it is.
Thet systemTest::SystemTestRunner class used several, somewhat hacky, file manipulation methods since we weren't on C++17 when they were written. Now those have all been replaced with calls from std::filesystem.
bcaddy
force-pushed
the
dev-tidyAndSumTweaks
branch
from
89e8e70
to
606ae53
Compare
There was a problem hiding this comment.
Actually this is a bug - the relevant header files are not included so chemistry builds break. Will add an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a handful of small tweaks and fixes I've been putting off while I worked on debugging MHD. Most are minor but I would like @evaneschneider or @bvillasen to take a look at my change to the grid temperature function. I think there might be other places that should be using MHD energy in computations but I don't know where
List of Changes
make tidyprint out where the results are stored. This isn't obvious so now it tells yousystemTest::SystemTestRunner::runL1ErrorTestwith a Kahan sum to avoid loss of precision.systemTest::SystemTestRunnerwithstd::filesystemcalls