Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create from memory #54

Merged
merged 3 commits into from
Jan 24, 2016
Merged

Create from memory #54

merged 3 commits into from
Jan 24, 2016

Conversation

tavianator
Copy link
Contributor

No description provided.

@kmike
Copy link
Contributor

kmike commented Oct 30, 2015

see also: #9

@tavianator
Copy link
Contributor Author

@kmike Huh, guess we should have scrolled down further on the pull requests page before we wrote this :) I like this version slightly better (const in more places, size_t vs int) but they're very similar.

@usptact
Copy link

usptact commented Nov 6, 2015

Thank you guys for keeping improving CRFSuite! Really appreciate that! I am using it almost daily to build models and glad to see that the tool is getting updates/fixes. The only sad thing that merges don't get that quickly into the master......

@kmike
Copy link
Contributor

kmike commented Nov 6, 2015

Thanks for working on it @tavianator! It is indeed sad PRs are not merged.
Yeah, #9 is indeed very similar; it had one extra feature - C++ interface was updated as well, but your version looks cleaner.

@chokkan
Copy link
Owner

chokkan commented Nov 6, 2015

I do appreciate your efforts for improving CRFsuite and exchanging the useful information. I apologize my late response for pull requests. I will do my best to review the code to integrate it. I will probably work on this in the next weekend as I have a lot of things to be done next week.

Thanks,
Naoaki

@tavianator
Copy link
Contributor Author

@kmike Good point! We don't use the C++ wrapper, but I'm happy to update it.

@chokkan No worries, thanks for writing CRFsuite!

@usptact
Copy link

usptact commented Dec 1, 2015

Bump

chokkan pushed a commit that referenced this pull request Jan 24, 2016
@chokkan chokkan merged commit a555b6f into chokkan:master Jan 24, 2016
chokkan pushed a commit that referenced this pull request Jan 24, 2016
@tavianator tavianator deleted the create-from-memory branch July 18, 2016 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants