Corrected necessary call to lbfgs_malloc before lbfgs is called. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allocated by liblbfgs instead of by the callee. The documentation for liblbfgs explicitly states that this pointer must be allocated by liblbfgs via `lbfgs_malloc`. This is due to its use of SSE optimised routes which may require longer arrays to be allocated than what is needed. This bug has caused us many bus errors due to liblbfgs being compiled with SSE optimisations.
timdawborn
changed the title
chokkan
pushed a commit
that referenced
this pull request
Jan 24, 2016
Corrected necessary call to lbfgs_malloc before lbfgs is called. (@timdawborn is absolutely right!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the
xpointer (2nd argument to liblbfgslbfgs) to be allocated by liblbfgs instead of by the callee. The documentation for liblbfgs explicitly states that this pointer must be allocated by liblbfgs vialbfgs_malloc. This is due to its use of SSE optimised routes which may require longer arrays to be allocated than what is needed.This bug has caused us many bus errors due to liblbfgs being compiled with SSE optimisations, and the
calloc'dwpointer being read by a SSE instruction/intrinsic when it's not aligned to a 16-byte boundary.