Conversation
…ner when LCG is enabled
|
Tick the box to add this pull request to the merge queue (same as
|
ArthurGodet
left a comment
There was a problem hiding this comment.
The code changes seem fine to me. The only remaining thing to dois change the number of expected nodes in tests in choco-parsers module.
Maybe we should consider removing these specific asserts (and keep only the ones of the objective value or number of solutions). What do you think ? @jgFages an opinion on the matter ?
|
In my opinion, we should keep these metrics. It is admittedly a bit of a pain to update them whenever we make a change that we know will affect them, but it also helps us spot regressions caused by other, indirect changes (such as, for example, when we change certain constraints). |
|
I would tend to agree with both :-) |
Some improvements to the LCG framework: