Set Expressions (with Chainable Format) for Arithmetic and Relational Operations #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PropagationInsight
…izeOf fails at estimating the size of the model.
- interlace n arrays - extract a sub-matrix from a matrix
…(ie, IOutputFactory)
* #1112 : fix bin packing initial propagation * move code initialising P and sumP from constructor to fullPropagation in PropBinPacking * clear R and P sets before full propagation in PropBinPacking
* Update maven-test.yml The runner version was bumped to 2.321 which rely on Ubuntu 24.4 instead of Ubuntu 22.04. And the default version Python is 3.12 instead of 3.10, which seems to make waf fails * Update maven-test.yml (ibex has its own job) * Update maven-test.yml (simplification)
…s to 1 + 2 views)
+ remove 'scores' structure from PickOnFil
Fix issues relative to enteringVariable and leavingVariable and how values close to 0. are managed
+add model and decision path to AbstractStrategy
+ delete ValueSortedMap.java
Can be used to map double to Identity-based objects
- Replace TObjectDoubleMap by Weightable for efficiency reason - Dom/WDeg now manages futvars (via Element) for itself and Dom/WDegRef - remove AbstractCriterionBasedVariableSelector#increase (only required by Dom/WDeg and Dom/WDegRef)
… The variables enqueued during each fixpoint that ends with failure are collected and their weights are update with the value `(l - i) / l` where l is the number of enqueued variables and i the position of the variable in the list. - reduce variants to one - remove PropagationInsight
…eActivity. + Change threshold to switch between Array and Map + remove call to `ensureCapacity` from `get`
Ibex: migrate script and workflow to v2.9.1 - update the installation steps from the ibex install script - update pom.xml to make tests work - change workflow to export LD_LIBRARY_PATH just before calling the test suite - add a dockerfile for test purpose
… existing structure for integer expressions. + update headers Suggestion of improvements: detect constraints like `partition(SetVar[] sets, SetVar universe)`
… existing structure for integer expressions. + update headers Suggestion of improvements: detect constraints like `partition(SetVar[] sets, SetVar universe)`
…ents' into gadavidd-set-expression-improvements
|
@cprudhom I believe that the first solution is more suitable for choco-solver. As far as I'm concerned, this approach is fine. In any case, I agree with whatever you think is best. The important thing is that we continue to contribute to the development of choco-solver. |
Member
Author
|
Ok, so in that case, I'll cherry-pick the files and create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gadavidd I wasn't able to push to your branch so I created a new one, namely
gadavidd-set-expression-improvements.It is based on your work (#1107), rebased upon the current version of
develop.It also includes some modifications to align the structure with what was done for int expressions.
Other solution: add my last commit to your branch and update your PR (in that case, authorship is clear).
Let me know your choice.