Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(build) (ENGTASKS-3694) Update Chocolatey.Cake.Recipe to latest #1051

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

corbob
Copy link
Member

@corbob corbob commented Jun 11, 2024

Description Of Changes

Update to latest Chocolatey.Cake.Recipe

Motivation and Context

Keeping repositories up to date with the version of Chocolatey.Cake.Recipe

Testing

  • Ran build.bat locally
  • Set a Team City build to run on this PR branch.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Build process changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

  • ENGTASKS-3694

@corbob corbob force-pushed the update-cake-recipe-support branch from d130c3f to 19d2802 Compare June 11, 2024 19:38
@corbob corbob requested a review from gep13 June 11, 2024 20:38
@corbob corbob self-assigned this Jun 11, 2024
@gep13 gep13 force-pushed the update-cake-recipe-support branch from 19d2802 to d0e7c92 Compare June 13, 2024 07:41
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The default shell on Windows runners is pwsh, but running the PSSA
task under pwsh was resulting in an error running `Install-Module`.
This error is not exhibited when running under Windows Powershell.
@gep13 gep13 merged commit 7db9368 into chocolatey:support/1.x Jun 13, 2024
2 checks passed
@gep13
Copy link
Member

gep13 commented Jun 13, 2024

@corbob thanks for getting this updated!

@corbob corbob deleted the update-cake-recipe-support branch June 13, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants