(#1003) Handle null keys during source translation #1010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
The helper class that is used whe looking up any translations that has
been made did not handle the translation source strings when they
are null or empty. This causes problems when especially looking up
description of Chocolatey settings items that by some reason did
not have a description associated with themself in the configuration
file.
Motivation and Context
We should not throw any exceptions when looking up translations that could abort the entire execution of Chocolatey GUI.
Testing
Build a release version of Chocolatey GUI and run the following on a completely new system.
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #1003