(GH-33) Resolve HyperV deprecation warning for differencing vs linked clone #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basictheprogram
added a commit
to basictheprogram/chocolatey-test-environment
that referenced
this pull request
Nov 29, 2018
Windows Server 2016 WIP chocolatey-community#31 but for Windows Server 2016
ferventcoder
reviewed
Dec 6, 2018
| @@ -50,7 +50,11 @@ Vagrant.configure("2") do |config| | |||
| # The time in seconds to wait for the virtual machine to report an IP address | |||
| v.ip_address_timeout = 130 | |||
| # Use differencing disk instead of cloning whole VHD | |||
| v.differencing_disk = true | |||
There was a problem hiding this comment.
When did we add the bit about differencing? Linked Clone is all I've used... hmm
There was a problem hiding this comment.
Nevermind, this is HyperV - good to see they are making the naming consistent (as they should be).
ferventcoder
changed the title
ferventcoder
changed the title
FranklinYu
force-pushed
the
fix/linked-clone
branch
from
bdc0f01
to
6581b2b
Compare
|
I amended the commit message to refer to the issue. |
|
Hey is there any update? Or anything I can help? |
|
@FranklinYu your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference:
https://github.com/hashicorp/vagrant/blob/v2.1.2/website/source/docs/hyperv/configuration.html.md
Technically speaking, even
requires 1.8.3, but I think nobody is using that old Vagrant anyway.
Closes #33