Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(k9s) Update to checksum extension to sha256 #2343

Merged

Conversation

danielkoek
Copy link
Contributor

@danielkoek danielkoek commented Nov 7, 2023

Description

In pr derailed/k9s#2153 they have changed the extension from txt to sha256, this change will make it possible to update k9s

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@danielkoek danielkoek changed the title Update to checksum extension to sha256 (k9s) Update to checksum extension to sha256 Nov 7, 2023
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@danielkoek
Copy link
Contributor Author

Hi @pauby,

Is there anything from preventing this to be merged?

I am not sure how to find out where the OWNER list is, which you mentioned the last time when the PR wasn't going through, so not sure who is now responsible for approving this.

@pauby
Copy link
Member

pauby commented Nov 28, 2023

@danielkoek The only thing holding up the review and merge is time from somebody to look at it. This is a Community maintained repository so most of it is done in people's spare time.

@AdmiringWorm
Copy link
Member

Hi @pauby,

Is there anything from preventing this to be merged?

I am not sure how to find out where the OWNER list is, which you mentioned the last time when the PR wasn't going through, so not sure who is now responsible for approving this.

The OWNERS list is the list of packages and users we have in the CODE_OWNERS file.

We have introduced a requirement that all packages need to be associated with one or more users that will be considered the primary maintainer of the package.

This package currently has no such maintainer. If you are willing to become the primary maintainer of the package, please add yourself to that list in the same format already present in that file.

By becoming the primary maintainer, this means you will be responsible for doing reviews of that package (merging the PR will still be us that does).

If you are not willing to become the primary maintainer, this PR will most likely be held until a primary maintainer becomes available.

Please also make sure you have read through our Contribution and Comitters guidelines.

@danielkoek
Copy link
Contributor Author

@pauby that makes complete sense! Thank you for letting me know

@AdmiringWorm I am more than happy to put myself on the primary maintainer for this package as it is something I work with daily it will be quite easy for me to see if the package is not being updated, I will push a new change to add myself to the list of owners!

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@pauby pauby mentioned this pull request Dec 21, 2023
4 tasks
@pauby
Copy link
Member

pauby commented Dec 21, 2023

Tested the update, install and uninstall and they were fine.

Thanks for the work here @danielkoek!

@pauby pauby merged commit 7d1f1e9 into chocolatey-community:master Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants