(#6) Remove helpers moved to compatibility package #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
6-core-extension-Remove-helpers-available-in-compatibility-package
branch
from
a405b7c to
6bd93fc
Compare
|
@vexx32 this PR is now ready for review |
|
scratch that, I rebased the wrong PR first |
AdmiringWorm
force-pushed
the
6-core-extension-Remove-helpers-available-in-compatibility-package
branch
from
6bd93fc to
14b2726
Compare
AdmiringWorm
force-pushed
the
6-core-extension-Remove-helpers-available-in-compatibility-package
branch
from
14b2726 to
88cd38f
Compare
|
@vexx32 and now this is actually ready 😄 |
vexx32
reviewed
Apr 11, 2022
AdmiringWorm
force-pushed
the
6-core-extension-Remove-helpers-available-in-compatibility-package
branch
from
7d4866b to
f7821c0
Compare
vexx32
reviewed
Apr 11, 2022
This commit updates the core extension package by removing the helpers that are available now in the compatibility package instead. Recommendation going forward is to take a reference on the compatibility package instead of the core extension if compatibility is of concern. Co-authored-by: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
AdmiringWorm
force-pushed
the
6-core-extension-Remove-helpers-available-in-compatibility-package
branch
from
f87195c to
3ba9e9c
Compare
|
@vexx32 I have updated the PR with the changes you suggested |
vexx32
approved these changes
Apr 12, 2022
AdmiringWorm
deleted the
6-core-extension-Remove-helpers-available-in-compatibility-package
branch
|
Awesome, thanks for taking a look at the PR's @vexx32. Now there is only the approval of the compatibility extension that is pending on CCR, then we are able to push a new version of this extension as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the core extension package by removing the helpers that where previously available in the package, but is now available in the compatibility package instead.
As there is a dependency on this compatibility package it is not considered a breaking change.
Requires #10 to be merged and this PR to be rebased of it afterwards.
fixes #6
https://app.clickup.com/t/20540031/ENGTASKS-1186