Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Minor Build Process Updates #44

Merged
merged 4 commits into from
Mar 11, 2024
Merged

(maint) Minor Build Process Updates #44

merged 4 commits into from
Mar 11, 2024

Conversation

corbob
Copy link
Contributor

@corbob corbob commented Mar 8, 2024 •
edited
Loading

Description Of Changes

Update the build process to:

  • Remove the GenerateDocs task that's not used.
  • Update GitHub Actions to use version 4 actions as the version 3 appear deprecated.
  • Update Team City to pull in the Pester results.
  • Minor grammar updates to markdown files.
  • Skip one of the Pester tests that is failing in production Team City.

Motivation and Context

Remove deprecated and unused CI tasks. Report the test results back to TeamCity builds.

Testing

Ran against dev Team City.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Build process updates.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

corbob added 3 commits March 8, 2024 17:47
@corbob
(maint) Remove unused docs build task
f793080 
The task to Generate Docs wasn't being used, and the script that it was
calling doesn't exist. This removes it from the build script. This also
updates the DEVEL.md document with the correct output directory and some
minor grammar cleanup.
@corbob
(maint) Gather the Pester Test Results CI build
956b14e 
TeamCity can report on the test results when told what xml file to look
at. This adds the configuration to pick up the Pester results for that
reporting.
@corbob
(maint) Skip test that is failing in TeamCity
bace683 
Another one of the mock tests is failing in TeamCity CI. Mark it to be
skipped for now.
@corbob corbob force-pushed the maint-add-testresults branch from 70c659b to bace683 Compare March 9, 2024 02:01
@corbob corbob changed the title Maint add testresults (maint) Minor Build Process Updates Mar 11, 2024
@corbob
(maint) Update GitHub Actions versions
c0aa645 
Update to newer GitHub Actions as node 16 is deprecated.
@corbob corbob requested a review from AdmiringWorm March 11, 2024 15:00
AdmiringWorm
AdmiringWorm approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corbob corbob marked this pull request as ready for review March 11, 2024 16:29
@AdmiringWorm AdmiringWorm merged commit 0de7db6 into chocolatey-community:develop Mar 11, 2024
1 check passed
@AdmiringWorm
Copy link
Member

@corbob thanks for getting this fixed up.

@corbob corbob deleted the maint-add-testresults branch March 11, 2024 16:50
@corbob corbob mentioned this pull request Mar 11, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdmiringWorm AdmiringWorm AdmiringWorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corbob @AdmiringWorm