Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#32) Add a build pipeline #42

Merged
merged 4 commits into from
Mar 8, 2024
Merged

(#32) Add a build pipeline #42

merged 4 commits into from
Mar 8, 2024

Conversation

corbob
Copy link
Contributor

@corbob corbob commented Mar 7, 2024 •
edited
Loading

Description Of Changes

  • Add a Team City build pipeline so that the module can be built automatically.
  • Add a GitHub Actions build pipeline for visibility into the automated builds.
  • Rename module to Chocolatey-AU and the corresponding Chocolatey package to chocolatey-au.

Motivation and Context

  • Make it more reliable to have a build of Chocolatey-AU
  • Allow the module to be released to PowerShell Gallery and Chocolatey Community Repository.

Testing

Operating Systems Testing

  • Windows 10 22H2 (Locally)
  • Team City agent
  • GitHub Action agent

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

@corbob
(chocolatey-community#32) Adjust repository layout for InvokeBuild
ec6d1e8 
Prepare the repository for building with InvokeBuild instead of with the
build script in the repository.
@corbob corbob self-assigned this Mar 7, 2024
@corbob corbob requested a review from AdmiringWorm March 7, 2024 04:16
@corbob corbob marked this pull request as draft March 7, 2024 04:26
@corbob
Copy link
Contributor Author

corbob commented Mar 7, 2024

The build was working flawlessly in GHA on my fork, as well as in TeamCity. But now it's failing on the PR here, so I will need to investigate what's going on there. Setting back to Draft for now as the GHA clearly doesn't work for PRs.

AdmiringWorm
AdmiringWorm requested changes Mar 7, 2024
View reviewed changes
Chocolatey-AU.build.ps1 Show resolved Hide resolved
Chocolatey-AU.build.ps1 Outdated Show resolved Hide resolved
Chocolatey-AU.build.ps1 Outdated Show resolved Hide resolved
GitReleaseManager.yaml Show resolved Hide resolved
GitVersion.yml Outdated Show resolved Hide resolved
chocolatey/chocolatey-au.nuspec Show resolved Hide resolved
src/Chocolatey-AU.psd1 Outdated Show resolved Hide resolved
src/Chocolatey-AU.psd1 Outdated Show resolved Hide resolved
src/Chocolatey-AU.psd1 Outdated Show resolved Hide resolved
src/Public/Update-Package.ps1 Show resolved Hide resolved
Windos
Windos previously requested changes Mar 7, 2024
View reviewed changes
.teamcity/settings.kts Outdated Show resolved Hide resolved
@corbob corbob force-pushed the 32-build-pipeline branch 2 times, most recently from 324b564 to 72894d5 Compare March 7, 2024 21:52
@corbob corbob marked this pull request as ready for review March 7, 2024 22:13
@corbob corbob force-pushed the 32-build-pipeline branch from 0782376 to bde86c1 Compare March 7, 2024 22:44
AdmiringWorm
AdmiringWorm reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the commit messages, this looks good to me. Can you rebase the commits and squash/reword any commits that don't follow our conventions?

@corbob corbob mentioned this pull request Mar 8, 2024
Open
corbob added 3 commits March 8, 2024 06:47
@corbob
(chocolatey-community#32) Add InvokeBuild script and rename project
71655e6 
Add in an InvokeBuild script and rename the project to Chocolatey-AU.
Using InvokeBuild will allow us to iterate on the build process more
easily as well as have distinct tasks in the build process
@corbob
(chocolatey-community#32) Adjust CI builds
aeee1d0 
Add the configuration for building on Team City and GitHub Actions. Also
remove the AppVeyor configuration.
@corbob
(maint) Add Release process issue template
dc6c854 
Add an Issue Template for the release process.
@corbob corbob force-pushed the 32-build-pipeline branch from f6eea2d to dc6c854 Compare March 8, 2024 14:47
AdmiringWorm
AdmiringWorm approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Windos if you could have another look over the teamcity settings, that would be great. As this targets the develop branch it can be safely merged once @Windos had the final look.

@Dwok09
Copy link

Dwok09 commented Mar 8, 2024

Cory asked me to take a look at this and the teamcity settings look correct to me now. I give approval to merge.

@JPRuskin JPRuskin requested a review from Windos March 8, 2024 18:38
@corbob corbob dismissed Windos’s stale review March 8, 2024 18:39

This was corrected.

@JPRuskin
Copy link

JPRuskin commented Mar 8, 2024

Raised a few things with Cory but am at agreement on fix-forward, merging as Derek currently can't but has otherwise approved this.

@JPRuskin JPRuskin merged commit 47332c1 into chocolatey-community:develop Mar 8, 2024
1 check passed
@corbob corbob deleted the 32-build-pipeline branch March 8, 2024 18:39
@corbob corbob linked an issue Mar 8, 2024 that may be closed by this pull request
Rename Module and Improve Build Pipeline to Increase Visibility and Reliability #32
Closed
@corbob corbob mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauby pauby pauby left review comments

@AdmiringWorm AdmiringWorm AdmiringWorm approved these changes

@Windos Windos Awaiting requested review from Windos

Assignees

@corbob corbob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Module and Improve Build Pipeline to Increase Visibility and Reliability
6 participants
@corbob @Dwok09 @JPRuskin @AdmiringWorm @Windos @pauby