Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename-project now also renames the organization name #83

Merged
merged 2 commits into from
Oct 25, 2020
Merged

feat: rename-project now also renames the organization name #83

merged 2 commits into from
Oct 25, 2020

Conversation

yann510
Copy link
Collaborator

@yann510 yann510 commented Oct 25, 2020 •
edited
Loading

closes #81

@coveralls
Copy link

coveralls commented Oct 25, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 326663629

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 326445069: 0.0%
Covered Lines: 36
Relevant Lines: 36
💛 - Coveralls

GabrielBottari
GabrielBottari requested changes Oct 25, 2020
View reviewed changes
Copy link
Member

@GabrielBottari GabrielBottari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also how come you're removing so much from the package lock? did you run npm install since the latest changes to master?

README.md Outdated
Thankfully, we have a script just for that:

```
npm run rename-project {YOUR_PROJECT_NAME}
npm run rename-project -- --organizationName {YOUR_ORGANIZATIO_NAME} --projectName {YOUR_PROJECT_NAME}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

organization*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since its already called rename-project maybe --organization is enough, same for --project

@yann510 yann510 merged commit a1c19b6 into master Oct 25, 2020
@yann510 yann510 deleted the 81-extend-rename-project branch October 25, 2020 02:32
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielBottari GabrielBottari GabrielBottari approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend rename-project.js script with repository owner/organization name
3 participants
@yann510 @coveralls @GabrielBottari