-
Notifications
You must be signed in to change notification settings - Fork 0
Add create_executable_makefile function to CMake build system #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
|
@copilot build CI failuje |
…lative path Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Fixed in commit ca5bd8e. The issue was that |
JohnAmadis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| DEFINITIONS = | ||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| # Initialization of paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot makefile'a dla dmod_loadera nie ruszaj. On ma być jak był bo to przykład
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit 39b9212. The dmod_loader Makefile and CMakeLists.txt have been reverted to their original state. The example remains as a manually maintained reference.
| @@ -0,0 +1,79 @@ | |||
| # ############################################################################## | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Możesz od razu dodać użycie tej nowej funkcji w narzędziach które się budują aktualnie poprzez add_dmod_tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit 39b9212. Added create_executable_makefile call to the dmod_add_tool function. Now all tools built with dmod_add_tool in the tools/ directory automatically get Makefiles generated (todmp and todmfc). Example tools in examples/ are excluded to preserve their manual Makefiles.
…tion to dmod_add_tool function Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
|
@copilot źle - sprawdz sobie co jest generowane dla statycznych bibliotek - łamiesz konwencję. Nie masz dawać ręcznie targetów tylko w tych generowanych załączać główny makefile. Możesz sobie przejrzeć narzędzia - one dobrze to robią, załączają główny system-tool.mk czy jakoś tak |
…nstead of defining targets manually Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Fixed in commit 2fa8590. The generated Makefiles now follow the convention - they define variables and include |
Task: Add create_executable_makefile function to CMake
The issue requests adding a
create_executable_makefilefunction similar to the existingcreate_library_makefilefunction. This function should create a Makefile for executable targets based on CMake data.Completed Implementation:
✅ All tasks completed successfully!
Changes Made:
scripts/Makefile-exe.in - New template file for generating executable Makefiles
$(DMOD_SYSTEM_TOOL_MK_FILE_PATH)instead of manually defining build targets$(DMOD_SLIB_FILE_PATH))scripts/CMakeLists.txt - New
create_executable_makefilefunctiondmod_add_toolfunction - Automatically generates Makefiles for build toolstools/directory (not for examples)tools/system/todmp/Makefile & tools/system/todmfc/Makefile - Auto-generated Makefiles
dmod_add_toolfunction$(DMOD_SYSTEM_TOOL_MK_FILE_PATH)which provides all build rulesexamples/system/dmod_loader/ - Preserved as manual example
Key Features:
dmod_add_tooltools/directorySecurity & Quality:
The implementation is complete and ready for use!
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.