Skip to content

Add DMOD_LOG_STEP macros to driver configuration #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnAmadis merged 3 commits into from
Mar 6, 2026
Merged

Add DMOD_LOG_STEP macros to driver configuration #30

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
973be41
Initial plan
Copilot Mar 6, 2026
1d7f8d1
Add DMOD_LOG_STEP macros to configure_driver for step-based logging
Copilot Mar 6, 2026
88fb544
Add DMOD_LOG_STEP_PROGRESS calls at each stage of configure_driver
Copilot Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/dmdevfs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,20 +901,24 @@ static int configure_drivers(dmfsi_context_t ctx, const char* driver_name, const
*/
static driver_node_t* configure_driver(const char* driver_name, dmini_context_t config_ctx)
{
DMOD_LOG_VERBOSE("Configuring driver: %s\n", driver_name);
DMOD_LOG_STEP_BEGIN("Configuring driver: %s\n", driver_name);
Copy link
Copy Markdown
Contributor

@JohnAmadis JohnAmadis Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot dodaj jeszcze użycie DMOD_LOG_STEP_PROGRESS - aby było można się domyśleć na czym ta konfiguracja sfailowała

Copy link
Copy Markdown
Contributor Author

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 88fb544. Added DMOD_LOG_STEP_PROGRESS at each stage of configure_driver:

  • 25% — Loading driver module
  • 50% — Resolving driver interface (dmdrvi_create)
  • 75% — Creating driver context
  • 90% — Reading driver node path

If a crash occurs at any stage, the last printed progress line will pinpoint exactly where in the configuration sequence the failure happened.

bool was_loaded = false;
bool was_enabled = false;
DMOD_LOG_STEP_PROGRESS(25, "Loading driver module: %s\n", driver_name);
Dmod_Context_t* driver = prepare_driver_module(driver_name, &was_loaded, &was_enabled);
if (driver == NULL)
{
DMOD_LOG_STEP(1, "Failed to configure driver: %s\n", driver_name);
return NULL;
}

DMOD_LOG_STEP_PROGRESS(50, "Resolving driver interface: %s\n", driver_name);
dmod_dmdrvi_create_t dmdrvi_create = Dmod_GetDifFunction(driver, dmod_dmdrvi_create_sig);
if (dmdrvi_create == NULL)
{
DMOD_LOG_ERROR("Driver module does not implement dmdrvi_create: %s\n", driver_name);
cleanup_driver_module(driver_name, was_loaded, was_enabled);
DMOD_LOG_STEP(1, "Failed to configure driver: %s\n", driver_name);
return NULL;
}

Expand All @@ -923,9 +927,11 @@ static driver_node_t* configure_driver(const char* driver_name, dmini_context_t
{
DMOD_LOG_ERROR("Failed to allocate memory for driver node: %s\n", driver_name);
cleanup_driver_module(driver_name, was_loaded, was_enabled);
DMOD_LOG_STEP(1, "Failed to configure driver: %s\n", driver_name);
return NULL;
}

DMOD_LOG_STEP_PROGRESS(75, "Creating driver context: %s\n", driver_name);
driver_node->was_loaded = was_loaded;
driver_node->was_enabled = was_enabled;
driver_node->driver = driver;
Expand All @@ -935,8 +941,10 @@ static driver_node_t* configure_driver(const char* driver_name, dmini_context_t
DMOD_LOG_ERROR("Failed to create driver context: %s\n", driver_name);
cleanup_driver_module(driver_name, was_loaded, was_enabled);
Dmod_Free(driver_node);
DMOD_LOG_STEP(1, "Failed to configure driver: %s\n", driver_name);
return NULL;
}
DMOD_LOG_STEP_PROGRESS(90, "Reading driver node path: %s\n", driver_name);
if(read_driver_node_path( driver_node, driver_node->path, sizeof(driver_node->path) ) != 0)
{
DMOD_LOG_ERROR("Failed to read driver node path: %s\n", driver_name);
Expand All @@ -947,10 +955,11 @@ static driver_node_t* configure_driver(const char* driver_name, dmini_context_t
}
cleanup_driver_module(driver_name, was_loaded, was_enabled);
Dmod_Free(driver_node);
DMOD_LOG_STEP(1, "Failed to configure driver: %s\n", driver_name);
return NULL;
}

DMOD_LOG_INFO("Configured driver: %s (path: %s)\n", driver_name, driver_node->path);
DMOD_LOG_STEP(0, "Configured driver: %s (path: %s)\n", driver_name, driver_node->path);

return driver_node;
}
Expand Down