fix: re-register view in registry on reattach after navigation #1
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When navigating away and back, the native view detaches (unregistering from viewRegistry via onDetachedFromWindow/willMove) and reattaches, but the recyclingKey prop setter short-circuits because the value hasn't changed. This leaves the view unregistered, causing all closeByKey/closeAll calls to silently fail. Adds re-registration in onAttachedToWindow (Android) and didMoveToWindow (iOS) so the view is always findable in the static registry after reattach. Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When navigating away from a screen containing swipeable rows and then navigating back, the native view detaches (
onDetachedFromWindowon Android /willMove(toSuperview: nil)on iOS) which unregisters the view from the staticviewRegistry. Upon reattach, therecyclingKeyprop setter short-circuits (if (oldValue == value) return) because the value hasn't changed, so the view is never re-registered.This causes all
closeByKey()/closeAll()calls to silently fail —getView(key)returnsnullbecause the registry entry was removed on detach and never restored.Fix
onAttachedToWindow()override that re-registers the view viaregisterView(this, recyclingKey)didMoveToWindow()whenwindow != nilviaSelf.registerView(self, for: key)How to reproduce (before fix)
<Swipeable>rows (e.g. a room list)After the fix, step 4 works correctly the row closes immediately on button press.