Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Adjustments #179

Merged
merged 7 commits into from
May 17, 2023
Merged

Build Adjustments #179

merged 7 commits into from
May 17, 2023

Conversation

yhakbar
Copy link
Contributor

@yhakbar yhakbar commented Apr 14, 2023

Adjustments to build targets to include an AWS Graviton target and strip binaries during cargo build, instead of doing so manually after the fact.

Unfortunately, for this to work, I had to abandon Windows builds, as I'm not familiar enough with Windows to figure out how to make that work.

This was referenced Apr 14, 2023
@yhakbar
Copy link
Contributor Author

yhakbar commented Apr 14, 2023

Not sure why the aarch64-apple-darwin binary fails to test. It executes just fine on an M1.

Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry for the delay!

I'm planning on reworking a lot of CI before next release, and this looks like a good jumping-off point. Just a couple small comments to get CI passing, and then I'll merge it :)

.github/workflows/publish.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@CosmicHorrorDev CosmicHorrorDev added C-enhancement Category: New feature or request A-CI Area: Relating to CI C-refactor Area: Every dev's favorite labels May 17, 2023
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Relating to CI C-enhancement Category: New feature or request C-refactor Area: Every dev's favorite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants