Skip to content

Fix SGR 1006 mouse mode behavior #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SGR 1006 mouse mode behavior #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions static/term.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,12 +552,12 @@ Terminal.prototype.bindMouse = function() {
pos.x -= 32;
pos.y -= 32;
self.send('\x1b[<'
+ ((button & 3) === 3 ? button & ~3 : button)
+ (button & 0x7f)
+ ';'
+ pos.x
+ ';'
+ pos.y
+ ((button & 3) === 3 ? 'm' : 'M'));
+ ((button & 128) ? 'm' : 'M'));
return;
}

Expand All @@ -581,7 +581,10 @@ Terminal.prototype.bindMouse = function() {
// 0 = left
// 1 = middle
// 2 = right
// 3 = release
// 3 = release (for normal/utf-8/urxvt)
//
// for mouse release event with SGR 1006 - 128 is added (private use)
//
// wheel up/down:
// 1, and 2 - with 64 added
switch (ev.type) {
Expand All @@ -597,7 +600,22 @@ Terminal.prototype.bindMouse = function() {
}
break;
case 'mouseup':
button = 3;
if (self.sgrMouse) {
button = ev.button != null
? +ev.button
: ev.which != null
? ev.which - 1
: null;

if (~navigator.userAgent.indexOf('MSIE')) {
button = button === 1 ? 0 : button === 4 ? 1 : button;
}

button += 128; // sgr mode release event

} else {
button = 3;
}
break;
case 'DOMMouseScroll':
button = ev.detail < 0
Expand Down Expand Up @@ -626,8 +644,12 @@ Terminal.prototype.bindMouse = function() {
mod = 0;
}

// increment to SP
button = (32 + (mod << 2)) + button;
button = (mod << 2) + button;

// increment to SP if mouse encoding is not SGR
if (!self.sgrMouse) {
button += 32;
}

return button;
}
Expand Down