Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just merged this in case someone wants to use it... #102

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

just merged this in case someone wants to use it... #102

wants to merge 19 commits into from

Commits on Jul 29, 2013

  1. save exit status of child via SIGCHLD handler and waitpid(3) 

    may be race-y due to always storing latest in global. might want to use
a map of some sort.
    Niall O'Higgins committed Jul 29, 2013
    Configuration menu
    Copy the full SHA
    b26759a View commit details
    Browse the repository at this point in the history

  2. use a PID -> exit code map to avoid race conditions.

    Niall O'Higgins committed Jul 29, 2013
    Configuration menu
    Copy the full SHA
    0e08d5d View commit details
    Browse the repository at this point in the history

  3. demonstrate fetching exit status

    Niall O'Higgins committed Jul 29, 2013
    Configuration menu
    Copy the full SHA
    11fb6fa View commit details
    Browse the repository at this point in the history

  4. zap status property which krept in.

    Niall O'Higgins committed Jul 29, 2013
    Configuration menu
    Copy the full SHA
    a4d9d51 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2013

  1. call node/libuv's SIGCHLD handler.

    Niall O'Higgins committed Aug 2, 2013
    Configuration menu
    Copy the full SHA
    2639c92 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2013

  1. fixing interoperability with native child_process. also added tests

    @jaredly
    jaredly committed Aug 3, 2013
    Configuration menu
    Copy the full SHA
    313e27e View commit details
    Browse the repository at this point in the history

  2. Merge pull request chjj#1 from jaredly/master 

    fixing interoperability with native child_process. also added tests
    Niall O'Higgins committed Aug 3, 2013
    Configuration menu
    Copy the full SHA
    46e9ed3 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2013

  1. must set exit status correctly

    Niall O'Higgins committed Aug 4, 2013
    Configuration menu
    Copy the full SHA
    1586aae View commit details
    Browse the repository at this point in the history

  2. set SA_NOCLDSTOP flag for SIGCHLD handler

    Niall O'Higgins committed Aug 4, 2013
    Configuration menu
    Copy the full SHA
    38a6b07 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2013

  1. node 0.10 compatibility

    @jaredly
    jaredly committed Aug 5, 2013
    Configuration menu
    Copy the full SHA
    e7e82c6 View commit details
    Browse the repository at this point in the history

  2. adding travis

    @jaredly
    jaredly committed Aug 5, 2013
    Configuration menu
    Copy the full SHA
    c7e72a5 View commit details
    Browse the repository at this point in the history

  3. missed test file

    @jaredly
    jaredly committed Aug 5, 2013
    Configuration menu
    Copy the full SHA
    e43d925 View commit details
    Browse the repository at this point in the history

  4. Merge pull request chjj#2 from jaredly/master 

    check the sigchld handler
    Niall O'Higgins committed Aug 5, 2013
    Configuration menu
    Copy the full SHA
    4e0de92 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2014

  1. fixing OSX build

    @soumith
    soumith committed Oct 13, 2014
    Configuration menu
    Copy the full SHA
    60f8056 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2014

  1. use new streams instead of old "data" API.

    @Gottox
    Gottox committed Nov 12, 2014
    Configuration menu
    Copy the full SHA
    c561711 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2014

  1. use Terminal.super_ instead of hard coded parent constructor.

    @Gottox
    Gottox committed Nov 13, 2014
    Configuration menu
    Copy the full SHA
    45b579d View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2015

  1. Merge pull request chjj#91 from soumith/master 

    fixing OSX build

* soumith/master:
  fixing OSX build
    @heavyk
    heavyk committed Jan 12, 2015
    Configuration menu
    Copy the full SHA
    f2e8ef5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request chjj#94 from Gottox/newStreams 

    Switch to new Streams API.

* Gottox/newStreams:
  use Terminal.super_ instead of hard coded parent constructor.
  use new streams instead of old "data" API.
    @heavyk
    heavyk committed Jan 12, 2015
    Configuration menu
    Copy the full SHA
    c5447a9 View commit details
    Browse the repository at this point in the history

  3. merge & version bump 

    Merge pull request chjj#37 from niallo/waitpid

Report status code of child process in `term.status` property

* niallo/waitpid:
	missed test file
	adding travis
	node 0.10 compatibility
	set SA_NOCLDSTOP flag for SIGCHLD handler
	must set exit status correctly
	fixing interoperability with native child_process. also added tests
	call node/libuv's SIGCHLD handler.
	zap status property which krept in.
	demonstrate fetching exit status
	use a PID -> exit code map to avoid race conditions.
	save exit status of child via SIGCHLD handler and waitpid(3) may be race-y due to always storing latest in global. might want to use a map of some sort.

Conflicts:
	lib/pty.js
	src/unix/pty.cc
    @heavyk
    heavyk committed Jan 12, 2015
    Configuration menu
    Copy the full SHA
    7b859c2 View commit details
    Browse the repository at this point in the history