Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On some circunstances compton will try and set decoration opacity on fullscreen windows #120

Open
rechapit opened this issue Jun 20, 2013 · 1 comment
Labels

Comments

@rechapit
Copy link

I managed to produce this issue while trying to run skyrim via wine.
compton will make the upper section of the window transparent where the window decoration would have been if not fullscreen.

the following patch works arround the issue

diff --git a/compton.c b/compton.c
index cffee1a..8f22bb2 100644
--- a/compton.c
+++ b/compton.c
@@ -1150,7 +1150,7 @@ paint_preprocess(session_t *ps, win *list) {
       {
         double frame_opacity_old = w->frame_opacity;

-        if (ps->o.frame_opacity && 1.0 != ps->o.frame_opacity
+        if ((!win_is_fullscreen(ps,w)) && ps->o.frame_opacity && 1.0 != ps->o.frame_opacity
             && win_has_frame(w))
           w->frame_opacity = get_opacity_percent(w) *
             ps->o.frame_opacity; 
@richardgv
Copy link
Collaborator

compton relies on _NET_FRAME_EXTENTS to determine the size of window frame, and adjusts when the property changes. If your full-screen window indeed has _NET_FRAME_EXTENTS set, compton is doing what it is supposed to do, and we could never fix a bug in your WM or application. I would recommend you to check _NET_FRAME_EXTENTS on your full-screen window with xprop.

And your patch will unfortunately not be merged into compton. There are cases when a full-screen window has a frame, and the logic doesn't sound like the best solution.

tryone144 pushed a commit to tryone144/compton that referenced this issue Dec 20, 2019
Closes chjj#120

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants