Skip to content
This repository was archived by the owner on Oct 5, 2020. It is now read-only.

Fix failed decode crash on iOS #25

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Fix failed decode crash on iOS #25

merged 1 commit into from
Jan 6, 2020

Conversation

@joextodd
Copy link
Contributor

@joextodd joextodd commented Jan 6, 2020

What: SDK crashes on a failed decode on iOS
Why: The FlutterStandardTypedData type cannot be initialised with nil bytes. Also need to set the argument to be Nullable.

Closes: #22

@joextodd joextodd added the bug Something isn't working label Jan 6, 2020
@joextodd joextodd requested a review from dinuchiriac January 6, 2020 17:21
@joextodd joextodd mentioned this pull request Jan 6, 2020
Closed
@dinuchiriac dinuchiriac merged commit daa025c into master Jan 6, 2020
@dinuchiriac dinuchiriac deleted the bug/ios-failed-decode branch January 6, 2020 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dinuchiriac dinuchiriac dinuchiriac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dinuchiriac dinuchiriac

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iOS crashes if invalid payload received

3 participants

@joextodd @dinuchiriac