* Clean up TODO.md: remove 8 resolved items, update 4 descriptions, add #162 regression test Phase 1 of TODO.md audit: - Delete resolved: #186 (release optimizations done), #163 (Termux works), TD-5 (termwiz revert), TD-6/#251/#252/#238 (SSH auth cluster — implementing next) - Update: TD-1 (narrow to dead code), TD-3 (fix file ref to api.rs:642-648), #192 (ConnectionWatcher already public), #7 (clarify remaining work) - Add regression test for #162: known_hosts in whitespace-containing paths (verifies russh+PathBuf handles spaces correctly), then delete #162 * Add SSH agent auth, tilde expansion, and passphrase prompting (#238, #251, #252) SSH authentication cluster fix addressing 4 interrelated issues: - **SSH agent support** (#238, #252): Try agent authentication before file-based keys. On Unix, connects via SSH_AUTH_SOCK. On Windows, tries OpenSSH named pipe then Pageant. Skipped when identities_only is set, matching standard ssh behavior. - **Tilde expansion** (#251, #252): Expand ~ prefix in identity file paths from CLI options. ssh2-config-rs already expands tildes for config-sourced paths, but CLI-provided paths via --options were passed as raw PathBuf without expansion. - **Passphrase prompting** (#238): When a key file is encrypted and agent auth is unavailable, prompt the user for the passphrase instead of silently skipping the key. Uses the existing SshAuthHandler infrastructure (works in both CLI and plugin/neovim contexts). - **HostName + IdentityFile verification**: Confirmed that SSH config is queried by the original host alias (not the resolved hostname), so IdentityFile directives from Host blocks are correctly applied. This was already working correctly in the codebase. * Refactor SSH auth into dedicated module, fix known_hosts tilde expansion Extract auth helpers from lib.rs into auth.rs module, reducing authenticate() from ~390 lines to ~70. Fix missing expand_tilde on known_hosts paths and Windows Pageant &mut Handle bug. Add unit and integration tests for encrypted key auth, identities_only, and error paths. * Polish auth module: traits for testability, mock tests, convention updates - Rewrite auth.rs module header to describe purpose, not provenance - Import AuthResult, KeyboardInteractiveAuthResponse, PrivateKeyWithHashAlg, MethodSet at module top; replace all inline type references - Introduce AuthSession trait abstracting Handle<ClientHandler> auth methods; refactor load_and_try_key, try_keyboard_interactive, try_password_auth - Introduce AgentAuthenticator trait with HandleAgent wrapper; refactor authenticate_with_agent for mock-based testing - Add 30 mock-based unit tests covering all code paths in the 4 auth functions - Flatten 5 nested _tests modules in auth.rs and host_key_verification in lib.rs - Remove all separator comments from both test modules - Add anti-patterns 11-14, module doc style and import hygiene conventions, test organization rules, and new validator/implementor checks * Clean up lib.rs tests: remove 60 low-value tests, rename survivors to convention - Delete 28 tests duplicating auth.rs coverage (expand_tilde, format_methods, auth error messages, key file discovery, auth event fallbacks) - Delete 14 derive-trait tests (Clone, Debug, Hash, Eq — compiler guarantees) - Delete 11 zero-assertion "doesn't panic" tests with no behavioral value - Delete 4 redundant ssh_family tests and 3 per-field LaunchOpts default tests - Rename all ~90 surviving tests to <subject>_should_<behavior> convention - Consolidate 8 parse_ssh_config hostname-variant tests into 1 rstest - Fix smoke test assertions: unwrap + validate content instead of is_ok() - Rename test_keypair() helper to generate_keypair() * Polish SSH auth: rename HandleAgent, trim docs, use pattern matching * Replace RUSTFLAGS="-Dwarnings" with workspace lints, add plan-mode agent rule Workspace lints: add [workspace.lints.clippy] all=deny and [workspace.lints.rust] warnings=deny to root Cargo.toml, inherit in all 6 crates. Remove -Dwarnings from CI/release RUSTFLAGS, agent definitions, and CLAUDE.md commands. Plan-mode: add "Plan-Mode Requirements" section to CLAUDE.md requiring every plan to declare agent usage, execution order, and justification for skipped stages.

Provide API for receiving notifications for connection status changes #192

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions