Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

LoadMemoryAnnotation uses deprecated ComponentName #1137

Open
chick opened this issue Jul 26, 2019 · 0 comments
Open

LoadMemoryAnnotation uses deprecated ComponentName #1137

chick opened this issue Jul 26, 2019 · 0 comments
Assignees
Milestone

Comments

@chick
Copy link
Contributor

chick commented Jul 26, 2019

Type of issue: Code cleanup, release issue

Description:
The LoadMemoryAnnotation uses a ComponentName annotation to
describe the Memory to be loaded. We should eliminate deprecations like this

What is the expected behavior?

The code is clean without these warnings. If we do not fix or fail to mark the
LoadMemoryAnnotation as also deprecated we limit our ability to follow
through on removing the deprecated code on the next API changing release

Strategy:
I think the answer here is that we need to deprecate LoadMemoryAnnotation and create a new parallel one that uses ReferenceTarget or other modern for of firrtl locator

@chick chick added this to the 1.2.X milestone Jul 26, 2019
@chick chick self-assigned this Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant