scripts/yosys: Tolerate 'show' failures as non-fatal#218
Merged
donn merged 1 commit intochipfoundry:mainfrom Oct 16, 2023
Merged
scripts/yosys: Tolerate 'show' failures as non-fatal#218donn merged 1 commit intochipfoundry:mainfrom
donn merged 1 commit intochipfoundry:mainfrom
Conversation
It's actually useful to be able to run 'empty' designs through the flow and unfortunately 'show' command fails with "Nothing to show" ... So because the 'show' is just a "nice to have" make any failure non-fatal. Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
donn
approved these changes
Oct 15, 2023
Collaborator
donn
left a comment
donn
left a comment
There was a problem hiding this comment.
Makes sense, will merge in the 'morrow assuming nothing catches fire
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's actually useful to be able to run 'empty' designs through the flow and unfortunately 'show' command fails with "Nothing to show" ... So because the 'show' is just a "nice to have" make any failure non-fatal.