Skip to content

cloudstack_ruby_client restructured #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chipchilders merged 3 commits into from
Aug 7, 2013
Merged

cloudstack_ruby_client restructured #4

chipchilders merged 3 commits into from
Aug 7, 2013

Conversation

@isaacchiang
Copy link
Collaborator

@isaacchiang isaacchiang commented Aug 7, 2013

Changes:

  1. Use a meta method to generate the api command for client
  2. Move out the response parsing block to meta method for generating appropriate error message
  3. Slightly modify the unit test to be more structured

chipchilders added a commit that referenced this pull request Aug 7, 2013
@chipchilders
Merge pull request #4 from isaacchiang/master
91e2bcc 
cloudstack_ruby_client restructured
@chipchilders chipchilders merged commit 91e2bcc into chipchilders:master Aug 7, 2013
@chipchilders
Copy link
Owner

chipchilders commented Aug 7, 2013

Isaac - I've published your changes to rubygems.org as version 0.1.0. Thanks for the patches!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacchiang @chipchilders