Implement Print::availableForWrite #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in arduino/Arduino#5789 Not implemented yet for USB serial, as that is harder
eric-wieser
force-pushed
the
availableForWrite
branch
from
2d3f541 to
cb5a3cc
Compare
eric-wieser
commented
May 23, 2017
| // default to zero, meaning "a single write may block" | ||
| // should be overriden by subclasses with buffering | ||
| virtual int availableForWrite() { return 0; } | ||
|
|
There was a problem hiding this comment.
This is taken straight from arduino/Arduino
|
This seems just fine to me. @majenkotech any issues with this PR? |
|
Looks good to me. Simple test of the TX buffer full bit, and a virtual default function. Not sure how we would go about implementing this for the USB though - have to dig into the TX implementation. |
|
Agreed. That's going to be a bit more work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in arduino/Arduino#5789
Not implemented yet for USB serial, as that is harder.
That shouldn't stop this patch being merged though - without this change, some Arduino code won't even compile.