Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ready for V3 #314

Merged
merged 80 commits into from
Sep 22, 2020
Merged

Ready for V3 #314

merged 80 commits into from
Sep 22, 2020

Conversation

chintan9
Copy link
Owner

@chintan9 chintan9 commented Sep 21, 2020 •
edited
Loading

Ready for V3 @iwatakeshi

This change is Reviewable

Takeshi Iwana and others added 30 commits July 12, 2020 20:15
Add prettier
88391d5
Update packages
7f6d648
Add typescript
e91b72d
Convert lib to typescript
9f48426
Update package-lock
d6f6b07
Add types
0636271
Update options
00e1a36
Add source
71f59b7
Fix build
ccc48ec
Move source from options to prop
569883c
Make source optional
ea545a7
Move files and fix types
94649ae
@chintan9
update
d5a90ef
@chintan9
add docz
b18a2b4
@chintan9
Merge pull request #260 from iwatakeshi/master
b8b1ff0 
Try to move TS by iwatakeshi #258
Fix styleguide
c4179f1
Update eslintrc
4bd4aba
Update package.json
8657951
Add default props and validation
06632ef
Disable eslint for prop type
546b06f
Update readme
1ad8ab6
Clean up rollup config
9b9f80b
@iwatakeshi
Fix main and module in package.json
aa2cae6
@iwatakeshi
Include source directory in tsconfig.json
f0fb9f9
@chintan9
add ts
a664388
@chintan9
merge
5a689d8
@chintan9
add more node
e9786b8
@chintan9
merge fix
4beb023
@chintan9
fix
0b71a20
@chintan9
fix
c80267c
chintan9 and others added 17 commits July 15, 2020 16:35
@chintan9
Merge pull request #267 from chintan9/v3-ts
a2431b5 
V3 ts
@chintan9
remove qawolf
13170fc
@dependabot-preview
Bump @testing-library/dom from 7.0.4 to 7.21.1
4e0de3f 
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library) from 7.0.4 to 7.21.1.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases)
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/dom-testing-library@v7.0.4...v7.21.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@iwatakeshi
Merge remote-tracking branch 'upstream/dependabot/npm_and_yarn/testin…
cb9e925 
…g-library/dom-7.21.1'
@chintan9
Merge pull request #264 from chintan9/v3-master
a09216a 
V3 master to v3-ts
@iwatakeshi
Merge remote-tracking branch 'upstream/v3-ts'
e1e2cbe
@iwatakeshi
Use memoization
952f43e
@iwatakeshi
Update packages
3c25832
@iwatakeshi
Use babel to transpile TypeScript
3f0ed54
@iwatakeshi
Update packages
b23a320
@iwatakeshi
Update lockfile
bbd1059
@iwatakeshi
Update readme
09ccabc
@iwatakeshi
Explicitly create a type definition
e86eb3d
@chintan9
Merge pull request #281 from iwatakeshi/master
bffc87d 
Changes to Plyr and the Build Pipeline
@chintan9
remove docz
31fefba
@chintan9
remove docz
1b28392
@chintan9
remove qawolf
a4dc602
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 21, 2020
@pull-assistant
Copy link

pull-assistant bot commented Sep 21, 2020 •
edited
Loading

Score: 0.87

Best reviewed: commit by commit

Optimal code review plan (25 warnings)

     Add prettier

Update packages

package.json 82% changes removed in Merge pull request #...

Add typescript

rollup.config.js 95% changes removed in Use babel to transpi...

Convert lib to typescript

src/plyr/styles.css 50% changes removed in Move files and fix t...

.../plyr/PlyComponent.examples.md 67% changes removed in Fix styleguide

src/plyr.d.ts 59% changes removed in Move files and fix t...

     Update package-lock

     Add types

     Update options

Add source

src/plyr/PlyrComponent.tsx 50% changes removed in Move source from opt...

src/plyr.d.ts 80% changes removed in Move files and fix t...

Fix build

package.json 81% changes removed in Update packages

rollup.config.js 70% changes removed in Use babel to transpi...

Move source from options to prop

src/plyr/PlyrComponent.tsx 44% changes removed in Add default props an...

     Make source optional

Move files and fix types

src/PlyrComponent.tsx 50% changes removed in Add default props an...

     update

add docz

package.json 60% changes removed in Update packages

Merge pull request #260 from iwatakeshi/master

rollup.config.js 91% changes removed in Use babel to transpi...

.../plyr/PlyComponent.examples.md 67% changes removed in Merge pull request #...

Fix styleguide

styleguide.config.js 78% changes removed in Merge remote-trackin...

Update eslintrc

.eslintrc.json 56% changes removed in Merge pull request #...

Update package.json

package.json 43% changes removed in Merge pull request #...

     Add default props and validation

     Disable eslint for prop type

     Update readme

     Clean up rollup config

Fix main and module in package.json

package.json 50% changes removed in Merge pull request #...

     Include source directory in tsconfig.json

add ts

src/plyr/styles.css 50% changes removed in Merge pull request #...

package.json 42% changes removed in Explicitly create a ...

rollup.config.js 45% changes removed in Use babel to transpi...

merge

package.json 73% changes removed in remove qawolf

.gitignore 63% changes removed in Merge remote-trackin...

     add more node

     merge fix

     fix

     fix

     Merge branch 'v3-ts' of https://github.com/chintan9/plyr-react into v3...

     Update UseEffect dependencies. Fixes #212

     Update nodejs.yml

     Update nodejs.yml

     update typo ci

     Use any for source prop type to prevent warnings

     Merge branch 'v3-ts' of https://github.com/chintan9/plyr-react into v3...

     fix typo

     Add new line

     Remove unused object

Merge pull request #263 from chintan9/v3-ts

.github/workflows/nodejs.yml 50% changes removed in Update nodejs.yml

package.json 67% changes removed in Update packages

     Update

     fix

     Update nodejs.yml

     Merge branch 'v3-master' of https://github.com/chintan9/plyr-react int...

add

.docz/.eslintrc.json 92% changes removed in remove docz

     Update UseEffect dependencies. Fixes #215

     Use any for source prop type to prevent warnings

     Add new line

     Remove unused object

     Merge remote-tracking branch 'origin/master'

     Add newline

Rename file PlyrComponent -> Plyr for consistency

.typo-ci.yml 50% changes removed in Merge pull request #...

     Remove lockfile

     Generate new lockfile

Merge remote-tracking branch 'refs/remotes/upstream/v3-ts'

.docz/.eslintrc.json 96% changes removed in remove docz

package.json 60% changes removed in remove docz

.docz/app/db.json 51% changes removed in remove docz

.github/workflows/nodejs.yml 50% changes removed in Merge pull request #...

     Ignore typo

     update docz

     add space

     fix typo

Merge pull request #262 from iwatakeshi/master

tsconfig.json 50% changes removed in Merge pull request #...

.eslintrc.json 50% changes removed in Merge pull request #...

package.json 45% changes removed in remove docz

     Merge pull request #267 from chintan9/v3-ts

     remove qawolf

     Bump @testing-library/dom from 7.0.4 to 7.21.1

     Merge remote-tracking branch 'upstream/dependabot/npm_and_yarn/testing...

     Merge pull request #264 from chintan9/v3-master

Merge remote-tracking branch 'upstream/v3-ts'

package-lock.json 48% changes removed in merge fix

Use memoization

src/Plyr.tsx 59% changes removed in Merge pull request #...

     Update packages

Use babel to transpile TypeScript

package.json 75% changes removed in Merge pull request #...

Update packages

package-lock.json 44% changes removed in merge fix

Update lockfile

package-lock.json 43% changes removed in merge fix

     Update readme

     Explicitly create a type definition

     Merge pull request #281 from iwatakeshi/master

     remove docz

     remove docz

     remove qawolf

     remove docz

     merge fix

Powered by Pull Assistant. Last update 88391d5 ... 4c2d104. Read the comment docs.

@vizipi
Copy link

vizipi bot commented Sep 21, 2020 •
edited
Loading

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
70.83 % Takeshi Iwana 25 17

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
.github/workflows/qawolf.yml50.00 %1 out of 2 times
plyr-react/package.json50.00 %1 out of 2 times
plyr-react/.babelrc50.00 %1 out of 2 times
plyr-react/.npmignore50.00 %1 out of 2 times

Committed file ranks

(click to expand)
  • 99.57%[package-lock.json]
  • 99.13%[package.json]
  • 83.55%[.typo-ci.yml]
  • 0.00%[src/lib/components/PlyrComponent/styles.css]
  • 89.61%[src/lib/components/PlyrComponent/PlyrComponent.examples.md]
  • 76.62%[src/index.ts]
  • 89.61%[styleguide.config.js]
  • 93.07%[.qawolf/tests/firstTest.test.js]
  • 83.55%[src/lib/index.js]
  • 87.01%[src/lib/components/PlyrComponent/PlyrComponent.test.js]

    • @guardrails
    Copy link

    guardrails bot commented Sep 21, 2020 •
    edited
    Loading

    All previously detected findings have been fixed. Good job! 👍🎉

    We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

    👉 Go to the dashboard for detailed results.

    📥 Happy? Share your feedback with us.

    @sourcelevel-bot
    Copy link

    SourceLevel has finished reviewing this Pull Request and has found:

    • 1 possible new issue (including those that may have been commented here).
    • 8 fixed issues! 🎉

    See more details about this review.

    @chintan9 chintan9 self-assigned this Sep 21, 2020
    @iwatakeshi
    Copy link
    Collaborator

    LGTM

    @chintan9 chintan9 merged commit 3983255 into master Sep 22, 2020
    @trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Sep 22, 2020
    @chintan9 chintan9 deleted the v3-master branch October 27, 2020 19:21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees

    @chintan9 chintan9

    Labels
    ✨ Merged Pull Request has been merged successfully
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @chintan9 @iwatakeshi