-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 ts #263
Conversation
Try to move TS by iwatakeshi #258
Best reviewed: commit by commit
Optimal code review plan (6 warnings)
|
src/plyr/styles.css
Outdated
} | ||
|
||
.PlyrComponent:active:after { | ||
.plyr-react:active:after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule doesn't have all its properties in alphabetical order.
src/plyr/styles.css
Outdated
} | ||
|
||
.PlyrComponent:after { | ||
content: ""; | ||
.plyr-react:after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule doesn't have all its properties in alphabetical order.
src/plyr/styles.css
Outdated
@@ -1,22 +1,23 @@ | |||
.PlyrComponent { | |||
.plyr-react { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule doesn't have all its properties in alphabetical order.
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks(click to expand)98.88% [package.json] 34.64% [.typo-ci.yml] 94.41% [.github/workflows/nodejs.yml] 34.64% [src/plyr/PlyrComponent.test.tsx] 99.44% [package-lock.json] 34.64% [src/index.d.ts] 84.92% [src/plyr.d.ts] 34.64% [src/plyr/PlyrComponent.d.ts] 88.27% [src/lib/components/PlyrComponent/PlyrComponent.test.js] 34.64% [src/plyr/PlyrComponent.test.d.ts] |
This change is