Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 ts #263

Merged
merged 22 commits into from
Jul 14, 2020
Merged

V3 ts #263

merged 22 commits into from
Jul 14, 2020

Conversation

chintan9
Copy link
Owner

@chintan9 chintan9 commented Jul 14, 2020

This change is Reviewable

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 14, 2020
@pull-assistant
Copy link

pull-assistant bot commented Jul 14, 2020

Score: 0.96

Best reviewed: commit by commit


Optimal code review plan (6 warnings)

     Add prettier

Update packages

package.json 62% changes removed in Merge pull request #...

Add typescript

rollup.config.js 91% changes removed in Merge pull request #...

     Convert lib to typescript

Update package-lock

package-lock.json 53% changes removed in Merge pull request #...

     Add types

     Update options

Add source

src/plyr/PlyrComponent.tsx 50% changes removed in Move source from opt...

Fix build

package.json 61% changes removed in Merge pull request #...

rollup.config.js 50% changes removed in Merge pull request #...

     Move source from options to prop

     Make source optional

     Merge pull request #260 from iwatakeshi/master

merge

package.json 55% changes removed in fix

     merge fix

     fix

     fix

     Merge branch 'v3-ts' of https://github.com/chintan9/plyr-react into v3...

     Update nodejs.yml

     Update nodejs.yml

     update typo ci

     Merge branch 'v3-ts' of https://github.com/chintan9/plyr-react into v3...

     fix typo

Powered by Pull Assistant. Last update 88391d5 ... 798db64. Read the comment docs.

}

.PlyrComponent:active:after {
.plyr-react:active:after {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule doesn't have all its properties in alphabetical order.

}

.PlyrComponent:after {
content: "";
.plyr-react:after {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule doesn't have all its properties in alphabetical order.

@@ -1,22 +1,23 @@
.PlyrComponent {
.plyr-react {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule doesn't have all its properties in alphabetical order.

@vizipi
Copy link

vizipi bot commented Jul 14, 2020

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
90.00 % Takeshi Iwana 11 18

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
styleguide/index.html50.00 %1 out of 2 times
plyr-react/.babelrc50.00 %1 out of 2 times
plyr-react/examples/src/index.js50.00 %1 out of 2 times
plyr-react/examples/src/styles.css50.00 %1 out of 2 times
plyr-react/package-lock.json50.00 %1 out of 2 times
plyr-react/examples/src/index.html50.00 %1 out of 2 times
plyr-react/src/style.css50.00 %1 out of 2 times
plyr-react/webpack.config.js50.00 %1 out of 2 times
plyr-react/package.json50.00 %1 out of 2 times
plyr-react/.npmignore50.00 %1 out of 2 times

Committed file ranks

(click to expand)
  • 98.88%[package.json]
  • 34.64%[.typo-ci.yml]
  • 94.41%[.github/workflows/nodejs.yml]
  • 34.64%[src/plyr/PlyrComponent.test.tsx]
  • 99.44%[package-lock.json]
  • 34.64%[src/index.d.ts]
  • 84.92%[src/plyr.d.ts]
  • 34.64%[src/plyr/PlyrComponent.d.ts]
  • 88.27%[src/lib/components/PlyrComponent/PlyrComponent.test.js]
  • 34.64%[src/plyr/PlyrComponent.test.d.ts]
  • @chintan9 chintan9 merged commit 67fc75d into v3-master Jul 14, 2020
    @trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Jul 14, 2020
    @trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 14, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ✨ Merged Pull Request has been merged successfully
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant