Skip to content

Commit

Permalink
doc: add issue reference to github pr template
Browse files Browse the repository at this point in the history
The PR template should include a Reference isssue (Fixes #issue_number)
so the PR can be tracked back to the issue easily.For a beginner trying
to read PRs to become comfortable with the codebase,it is really helpful
if one can directly reach the issue the PR fixes.

Fixes: nodejs#36338
  • Loading branch information
chinmoy12c committed Dec 8, 2020
1 parent ca8eb79 commit 9b3eb77
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->

#### Related Issues

Fixes: https://github.com/nodejs/node/issues/<issue_number>

##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Expand Down
4 changes: 4 additions & 0 deletions doc/guides/contributing/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,10 @@ Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->

#### Related Issues

Fixes: https://github.com/nodejs/node/issues/<issue_number>

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

Expand Down

0 comments on commit 9b3eb77

Please sign in to comment.