fixed infinite loop when jQuery is loaded #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an important fix. I just spent a while narrowing down a JS lock-up and arrived at the exact same code change. I am using bower to include this module. Please merge. |
|
Please merge. Also seeing the issue on angular 1.2.28; this fixes it. |
soyuka
added a commit
that referenced
this pull request
Feb 12, 2015
fixed infinite loop when jQuery is loaded
Collaborator
|
Merged but I can't publish to bower. |
Author
|
when using jQuery, additional props are added to arrays returned by .find() and are reached with "for(var i in ...)" syntax, causing an infinite loop. Proper "for" syntax fixes it. |
|
+1 for bower package |
|
+1 for bower package……… |
|
yes +1. updating bower would be great! |
|
+1 update bower package plz! |
mistydemeo
pushed a commit
to artefactual-labs/appraisal-tab
that referenced
this pull request
Jan 8, 2016
Merged upstream as chinmaymk/angular-charts#187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will fix #154