Skip to content

Commit

Permalink
fix: change passkey wording
Browse files Browse the repository at this point in the history
Update i18n property 'Save a passkey' to 'Create a passkey' and 'Add passkey' to 'Create a passkey' in three locations: headline, button, and link, across multiple languages.
  • Loading branch information
vishalkhoje authored Oct 4, 2023
1 parent 994c1dd commit 3eaa7bc
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 17 deletions.
4 changes: 2 additions & 2 deletions e2e/pages/RegisterAuthenticator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ export class RegisterAuthenticator extends BasePage {
constructor(page: Page) {
super(page);
this.setUpPasskeyButton = page.locator("button[type=submit]", {
hasText: "Save a passkey",
hasText: "Create a passkey",
});
this.skipLink = page.locator("button", {
hasText: "Skip",
});
this.headline = page.locator("h1", { hasText: "Save a passkey" });
this.headline = page.locator("h1", { hasText: "Create a passkey" });
}

async registerPasskey() {
Expand Down
2 changes: 1 addition & 1 deletion e2e/tests/passwordless.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ test.describe("@nopw", () => {
},
});

test(`Register, add passkey, logout, login with passkey with authenticator transport ${transport}`, async ({
test(`Register, Create a passkey, logout, login with passkey with authenticator transport ${transport}`, async ({
loginEmailPage,
registerConfirmPage,
loginPasscodePage,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const AddPasskeyDropdown = ({
return (
<Dropdown
name={"add-passkey-dropdown"}
title={t("labels.addPasskey")}
title={t("labels.createPasskey")}
checkedItemIndex={checkedItemIndex}
setCheckedItemIndex={setCheckedItemIndex}
>
Expand Down
6 changes: 3 additions & 3 deletions frontend/elements/src/i18n/de.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const de: Translation = {
loginFinished: "Login erfolgreich",
loginPasscode: "Passcode eingeben",
loginPassword: "Passwort eingeben",
registerAuthenticator: "Passkey einrichten",
registerAuthenticator: "Erstellen Sie einen passkey",
registerConfirm: "Konto erstellen?",
registerPassword: "Neues Passwort eingeben",
profileEmails: "E-Mails",
Expand Down Expand Up @@ -76,7 +76,7 @@ export const de: Translation = {
forgotYourPassword: "Passwort vergessen?",
back: "Zurück",
signInPasskey: "Anmelden mit Passkey",
registerAuthenticator: "Passkey einrichten",
registerAuthenticator: "Erstellen Sie einen passkey",
signIn: "Anmelden",
signUp: "Registrieren",
sendNewPasscode: "Neuen Code senden",
Expand All @@ -93,7 +93,7 @@ export const de: Translation = {
newPasskeyName: "Neuer Passkey Name",
addEmail: "E-Mail-Adresse hinzufügen",
changePassword: "Password ändern",
addPasskey: "Passkey hinzufügen",
createPasskey: "Erstellen Sie einen passkey",
webauthnUnsupported: "Passkeys werden von ihrem Browser nicht unterrstützt",
signInWith: "Anmelden mit {provider}",
deleteAccount: "Ja, dieses Konto löschen.",
Expand Down
6 changes: 3 additions & 3 deletions frontend/elements/src/i18n/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const en: Translation = {
loginFinished: "Login successful",
loginPasscode: "Enter passcode",
loginPassword: "Enter password",
registerAuthenticator: "Save a passkey",
registerAuthenticator: "Create a passkey",
registerConfirm: "Create account?",
registerPassword: "Set new password",
profileEmails: "Emails",
Expand Down Expand Up @@ -74,7 +74,7 @@ export const en: Translation = {
forgotYourPassword: "Forgot your password?",
back: "Back",
signInPasskey: "Sign in with a passkey",
registerAuthenticator: "Save a passkey",
registerAuthenticator: "Create a passkey",
signIn: "Sign in",
signUp: "Sign up",
sendNewPasscode: "Send new code",
Expand All @@ -91,7 +91,7 @@ export const en: Translation = {
newPasskeyName: "New passkey name",
addEmail: "Add email",
changePassword: "Change password",
addPasskey: "Add passkey",
createPasskey: "Create a passkey",
webauthnUnsupported: "Passkeys are not supported by your browser",
signInWith: "Sign in with {provider}",
deleteAccount: "Yes, delete this account.",
Expand Down
6 changes: 3 additions & 3 deletions frontend/elements/src/i18n/fr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const fr: Translation = {
loginFinished: "Connexion réussie",
loginPasscode: "Entrez le code d'accès",
loginPassword: "Entrez le mot de passe",
registerAuthenticator: "Enregistrer une clé d'identification",
registerAuthenticator: "Créer une clé d'identification",
registerConfirm: "Créer un compte ?",
registerPassword: "Définir un nouveau mot de passe",
profileEmails: "Adresses e-mail",
Expand Down Expand Up @@ -76,7 +76,7 @@ export const fr: Translation = {
forgotYourPassword: "Mot de passe oublié ?",
back: "Retour",
signInPasskey: "Se connecter avec une clé d'identification",
registerAuthenticator: "Enregistrer une clé d'identification",
registerAuthenticator: "Créer une clé d'identification",
signIn: "Se connecter",
signUp: "S'inscrire",
sendNewPasscode: "Envoyer un nouveau code",
Expand All @@ -93,7 +93,7 @@ export const fr: Translation = {
newPasskeyName: "Nouveau nom de clé d'identification",
addEmail: "Ajouter une adresse e-mail",
changePassword: "Changer le mot de passe",
addPasskey: "Ajouter une clé d'identification",
createPasskey: "Créer une clé d'identification",
webauthnUnsupported:
"Les clés d'identification ne sont pas prises en charge par votre navigateur",
signInWith: "Se connecter avec {provider}",
Expand Down
2 changes: 1 addition & 1 deletion frontend/elements/src/i18n/translations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export interface Translation {
newPasskeyName: string;
addEmail: string;
changePassword: string;
addPasskey: string;
createPasskey: string;
webauthnUnsupported: string;
signInWith: string;
deleteAccount: string;
Expand Down
6 changes: 3 additions & 3 deletions frontend/elements/src/i18n/zh.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const zh: Translation = {
loginFinished: "登录成功",
loginPasscode: "输入验证码",
loginPassword: "输入密码",
registerAuthenticator: "保存一把密钥",
registerAuthenticator: "创建密钥",
registerConfirm: "创建账号?",
registerPassword: "设置新密码",
profileEmails: "电子邮件",
Expand Down Expand Up @@ -68,7 +68,7 @@ export const zh: Translation = {
forgotYourPassword: "忘记密码了吗?",
back: "返回",
signInPasskey: "使用密钥登录",
registerAuthenticator: "设置新密钥",
registerAuthenticator: "创建密钥",
signIn: "登录",
signUp: "注册",
sendNewPasscode: "发送新代码",
Expand All @@ -85,7 +85,7 @@ export const zh: Translation = {
newPasskeyName: "新密钥名称",
addEmail: "添加电子邮件",
changePassword: "更改密码",
addPasskey: "添加密钥",
createPasskey: "创建密钥",
webauthnUnsupported: "您的浏览器不支持密钥",
signInWith: "通过 {provider} 登录",
deleteAccount: "是的,删除此帐户。",
Expand Down

0 comments on commit 3eaa7bc

Please sign in to comment.