feat(windows): Add WebView2 UWP Desktop support (react-native-webview…

…#2419) * feat(windows): Add WebView2 UWP Desktop support * remove expired cert * deploy from layout in ci
chiaramooney · Mar 28, 2022 · 5fb7b0c · 5fb7b0c
1 parent a7d2c66
commit 5fb7b0c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/windows-ci.yml b/.github/workflows/windows-ci.yml
@@ -42,13 +42,13 @@ jobs:
       run: yarn windows --release --no-packager --no-deploy --logging
 
     # Workaround for a bug in package searching during deploy.
-    # The deploy script only searches windows/{*/bin/x64/Release,Release/*}, but the build step above placed the pakcages at windows/x64/Release.
+    # The deploy script only searches windows/{*/bin/x64/Release,Release/*}, but the build step above placed the packages at windows/x64/Release.
     # Copy the packages to Windows/Release before deploying.
     - name: Deploy
       shell: powershell
       run: |
         Copy-Item -Path example\windows\x64\Release -Recurse -Destination example\windows\
-        npx react-native run-windows --arch x64 --release --root example --logging --no-build --no-packager
+        npx react-native run-windows --arch x64 --release --root example --logging --no-build --no-packager --deploy-from-layout
 
     - name: Start Appium server
       shell: powershell

diff --git a/example/app.json b/example/app.json
@@ -26,8 +26,6 @@
     ]
   },
   "windows": {
-    "appxManifest": "windows/Package.appxmanifest",
-    "certificateKeyFile": "windows/WebViewWindows_TemporaryKey.pfx",
-    "certificateThumbprint": "1DA6E34911B18C433FE3E543D0429FC808468C89"
+    "appxManifest": "windows/Package.appxmanifest"
   }
 }
diff --git a/example/windows/WebViewWindows_TemporaryKey.pfx b/example/windows/WebViewWindows_TemporaryKey.pfx
diff --git a/windows/ReactNativeWebView/ReactNativeWebView.vcxproj b/windows/ReactNativeWebView/ReactNativeWebView.vcxproj
@@ -147,6 +147,7 @@
     <None Include="packages.config" />
     <None Include="ReactNativeWebView.def" />
   </ItemGroup>
+
   <ItemGroup>
     <None Include="PropertySheet.props" />
   </ItemGroup>