Update expected browser title for Vitest #206
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hello @mattjennings, thanks for your contribution! Maybe we should handle both cases for backward compatibility? Can you please update the PR using array's |
Author
|
Sure I can do that, or we can check for "vitest" existing at all in the title (case-insensitively)? |
Member
|
Can I ask what happens to your tests with the current implementation? As long as I can see here, page title is still "Vitest Browser Runner", while "Vitest" is used for the UI page. I am not sure what we are fixing here 😄 |
Author
|
Oh, yes, this is because I was running the UI page. I didn't realize they were different titles :|. The UI page did work though after this change, maybe an array of either title is the way to go then. |
Member
|
I agree, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure when the title changed in vitest, but this will make it work with at least vitest 3.1.2.
Are there any plans to release v0.19 soon?