Add choice rename action and edit indicator #1099
Merged
+73
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAdds a discoverable rename flow: introduces a pencil icon in the Choice header, a "Rename" context-menu item, a prompt helper ( Changes
Sequence DiagramsequenceDiagram
participant User
participant Item as ChoiceListItem
participant List as ChoiceList
participant View as ChoiceView
participant Prompt as promptRenameChoice
participant Backend as Update & Persist
User->>Item: Open context menu & select "Rename"
Item->>List: dispatch renameChoice(choice)
List->>View: propagate renameChoice(choice)
View->>Prompt: promptRenameChoice(app, currentName)
Prompt->>User: show input prompt
User->>Prompt: submit new name
Prompt->>View: return newName | null
View->>View: validate & trim newName
alt newName changed
View->>Backend: updateChoiceHelper(choice, newName)
Backend->>Backend: refresh command registry
Backend->>Backend: persist changes
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying quickadd with
|
| Latest commit: |
69f07aa
|
| Status: | ⚡️ Build in progress... |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/gui/ChoiceBuilder/choiceBuilder.ts (1)
84-109:⚠️ Potential issue | 🟡 MinorPrevent empty/whitespace choice names in header rename.
This path allows blank names, while the ChoiceView rename trims/validates. Aligning behavior avoids empty labels and command naming issues.🔧 Proposed fix (trim + validate)
- const newName: string = await GenericInputPrompt.Prompt( + const newName: string = await GenericInputPrompt.Prompt( this.app, choice.name, "Choice name", choice.name, ); - if (newName !== choice.name) { - choice.name = newName; - textEl.setText(newName); - } + const trimmed = newName.trim(); + if (!trimmed || trimmed === choice.name) return; + choice.name = trimmed; + textEl.setText(trimmed);
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/gui/choiceRename.ts`:
- Around line 9-14: The Prompt call passes arguments in the wrong order to
GenericInputPrompt.Prompt (signature: Prompt(app, header, placeholder?, value?,
description?)); change the call so the header is "Choice name" and currentName
is passed as the value (e.g. Prompt(app, "Choice name", /* placeholder? */
undefined, currentName)), updating the invocation that assigns newName to use
GenericInputPrompt.Prompt(app, "Choice name", undefined, currentName).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #683
Summary by CodeRabbit
New Features
Style
✏️ Tip: You can customize this high-level summary in your review settings.